[breaking] Removed real_name field from gRPC Library message
#1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 36.58% // Head: 36.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1890 +/- ##
==========================================
+ Coverage 36.58% 36.74% +0.16%
==========================================
Files 231 231
Lines 19696 19720 +24
==========================================
+ Hits 7206 7247 +41
+ Misses 11659 11642 -17
Partials 831 831
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cmaglie
force-pushed
the
grpc_cleanup
branch
2 times, most recently
from
3b474e0 to
8e133de
Compare
per1234
requested changes
Oct 2, 2022
per1234
added
type: enhancement
Co-authored-by: per1234 <[email protected]>
3 tasks
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Oct 5, 2022
It has been removed from the gRPC API: arduino/arduino-cli#1890 This PR switches from `real_name` to `name` in the UI, as the `name` is the canonical form provided by the CLI. Closes #1525 Signed-off-by: Akos Kitta <[email protected]>
4 tasks
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Oct 5, 2022
It has been removed from the gRPC API: arduino/arduino-cli#1890 This PR switches from `real_name` to `name` in the UI, as the `name` is the canonical form provided by the CLI. Closes #1525 Signed-off-by: Akos Kitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Removed the
real_namefield from gRPC APIcommands.v1.LibraryLibrary.real_nameandLibrary.namehave the same values andreal_nameis deprecated.real_namehas been removedtitled accordingly?
Yes, as described above